Skip to content

Conversation

@fsih
Copy link
Contributor

@fsih fsih commented Aug 7, 2018

The basics

  • I branched from develop
  • My pull request is against develop
  • My code follows the style guide

Finish up #1819 by adding a TODO comment

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@fsih fsih force-pushed the bugfix/hidden_workspace branch from 05b7974 to e068071 Compare August 7, 2018 22:04
@fsih fsih changed the base branch from master to develop August 7, 2018 22:05
@fsih
Copy link
Contributor Author

fsih commented Aug 7, 2018

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

* @type {boolean}
* @package
*/
Blockly.WorkspaceSvg.prototype.isVisible = true;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make this @private isVisible_, adding getVisibility() to discourage workspace.isVisible = false;.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@fsih fsih force-pushed the bugfix/hidden_workspace branch from 2d698f5 to 4a34663 Compare August 9, 2018 01:10
@AnmAtAnm AnmAtAnm merged commit 05e0dc6 into RaspberryPiFoundation:develop Aug 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants