-
Notifications
You must be signed in to change notification settings - Fork 3.8k
Bugfix/hidden workspace #1996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix/hidden workspace #1996
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
05b7974 to
e068071
Compare
|
I signed it! |
|
CLAs look good, thanks! |
core/workspace_svg.js
Outdated
| * @type {boolean} | ||
| * @package | ||
| */ | ||
| Blockly.WorkspaceSvg.prototype.isVisible = true; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make this @private isVisible_, adding getVisibility() to discourage workspace.isVisible = false;.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
2d698f5 to
4a34663
Compare
The basics
Finish up #1819 by adding a TODO comment