Only take keypresses when visible #1674
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnmAtAnm
approved these changes
Aug 7, 2018
core/workspace_svg.js
Outdated
| * @type {boolean} | ||
| * @package | ||
| */ | ||
| Blockly.WorkspaceSvg.prototype.isVisible = true; |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
core/blockly.js
Outdated
| * @param {!Event} e Key down event. | ||
| * @private | ||
| */ | ||
| // TODO handle cases where there are multiple workspaces and non-main workspaces are able to accept |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
AnmAtAnm
approved these changes
Aug 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves
Fixes #1019
Proposed Changes
This change mirrors
RaspberryPiFoundation/blockly#1996
from Blockly
Reason for Changes
Keyboard shortcuts can't be implemented in other tabs as long as the blocks tab is responding to them
Test Coverage
Tested in integration with GUI by using ctrl Z, C, and V while in other tabs