fread gains index argument for setting secondary indices#2719
Merged
fread gains index argument for setting secondary indices#2719
Conversation
MichaelChirico
commented
Apr 1, 2018
Member
Author
There was a problem hiding this comment.
need to fix this, won't work correctly for atomic vector
MichaelChirico
force-pushed
the
fread_index_2633
branch
from
35e18c5 to
f370efb
Compare
Codecov Report
@@ Coverage Diff @@
## master #2719 +/- ##
==========================================
+ Coverage 93.41% 93.43% +0.02%
==========================================
Files 61 61
Lines 12281 12295 +14
==========================================
+ Hits 11472 11488 +16
+ Misses 809 807 -2
Continue to review full report at Codecov.
|
MichaelChirico
commented
Apr 1, 2018
| if (!all(sapply(index, is.character))) | ||
| stop("index argument of data.table() must be a character vector naming columns (NB: col.names are applied before this)") | ||
| if (is.list(index)) { | ||
| to_split = sapply(index, length) == 1L |
Member
Author
There was a problem hiding this comment.
i guess this should be vapply_1i
mattdowle
changed the title
mattdowle
approved these changes
Apr 9, 2018
Member
mattdowle
left a comment
mattdowle
left a comment
There was a problem hiding this comment.
Very nice. Especially that multi-column index can be specified either in c("col1","col2","col3") form or as "col1,col2,col3" and that both are acceptable is documented.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2633
Also fleshed out some more details in
?freadabout the order of arguments & improved the error for a badkeyargument, and simplified the test forsetindexvaccepting a list