Skip to content

Attempt to improve nqjoin test#2732

Merged
mattdowle merged 2 commits intomasterfrom
faster_nqjoin_test
Apr 9, 2018
Merged

Attempt to improve nqjoin test#2732
mattdowle merged 2 commits intomasterfrom
faster_nqjoin_test

Conversation

@mattdowle
Copy link
Copy Markdown
Member

Attempt to reduce resources needed due to fail in (unrelated) PR #2719.

 Running test id 1648.003      
 Running test id 1648.004      Error: memory exhausted (limit reached?)
 Error: memory exhausted (limit reached?)

Fairly minor improvements to speed/efficiency in the nqjoin tests 1641-1652. Steps taken towards simplification which might reduce many small objects a little bit; e.g. to avoid one level of lapply and a Reduce instead of lapply(,<<-)
The gc() is attempt to free heap a bit earlier once per test number.

@mattdowle mattdowle added this to the v1.10.6 milestone Apr 9, 2018
@codecov-io
Copy link
Copy Markdown

codecov-io commented Apr 9, 2018

Codecov Report

Merging #2732 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2732   +/-   ##
=======================================
  Coverage   93.41%   93.41%           
=======================================
  Files          61       61           
  Lines       12281    12281           
=======================================
  Hits        11472    11472           
  Misses        809      809

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45d5a9e...bccb234. Read the comment docs.

@mattdowle mattdowle merged commit bd1b282 into master Apr 9, 2018
@mattdowle mattdowle deleted the faster_nqjoin_test branch April 9, 2018 22:35
@mattdowle mattdowle mentioned this pull request Apr 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants