Conversation
Codecov Report
@@ Coverage Diff @@
## master #2733 +/- ##
=======================================
Coverage 93.43% 93.43%
=======================================
Files 61 61
Lines 12295 12295
=======================================
Hits 11488 11488
Misses 807 807Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More significant follow up to PR #2732 to reduce resources of nqjoin tests 1641-1652.
In
check(), row numbers are now gathered and then selected once afterwards, rather than making many small tables and then usingrbindlist(). Also, isolated theeval(e)from subset optimization which may have been at play, too.