Skip to content

fix shift issue when n character#3355

Merged
mattdowle merged 3 commits intomasterfrom
shift-n-string-fix
Feb 8, 2019
Merged

fix shift issue when n character#3355
mattdowle merged 3 commits intomasterfrom
shift-n-string-fix

Conversation

@jangorecki
Copy link
Copy Markdown
Member

closes #3354
defines shift in data.table.h file
because of that had to rename shift variable in gsum.c, it is now called bitshift.

@jangorecki jangorecki added this to the 1.12.2 milestone Feb 5, 2019
@HughParsonage
Copy link
Copy Markdown
Member

I could reproduce the segmentation fault outside of RStudio so maybe it should just refer to a segmentation fault rather than suggesting it's something peculiar to RStudio?

@jangorecki jangorecki changed the title fix shift RStudio issue, closes #3354 fix shift issue when n character, closes #3354 Feb 5, 2019
@mattdowle mattdowle changed the title fix shift issue when n character, closes #3354 fix shift issue when n character Feb 6, 2019
@mattdowle
Copy link
Copy Markdown
Member

mattdowle commented Feb 8, 2019

dt[, new_col := shift(val, NA_integer_)] was still crashing; fixed.

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 8, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@e043dd2). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #3355   +/-   ##
=========================================
  Coverage          ?   94.74%           
=========================================
  Files             ?       65           
  Lines             ?    12154           
  Branches          ?        0           
=========================================
  Hits              ?    11515           
  Misses            ?      639           
  Partials          ?        0
Impacted Files Coverage Δ
src/shift.c 99.16% <100%> (ø)
R/shift.R 94.11% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e043dd2...03856e5. Read the comment docs.

1 similar comment
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 8, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@e043dd2). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #3355   +/-   ##
=========================================
  Coverage          ?   94.74%           
=========================================
  Files             ?       65           
  Lines             ?    12154           
  Branches          ?        0           
=========================================
  Hits              ?    11515           
  Misses            ?      639           
  Partials          ?        0
Impacted Files Coverage Δ
src/shift.c 99.16% <100%> (ø)
R/shift.R 94.11% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e043dd2...03856e5. Read the comment docs.

@mattdowle mattdowle merged commit 240e724 into master Feb 8, 2019
@mattdowle mattdowle deleted the shift-n-string-fix branch February 8, 2019 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

shift crashes R when using n = "lead"

3 participants