Skip to content

better error msg when assign RHS is list column, closes #950#3457

Merged
mattdowle merged 4 commits intomasterfrom
assign-rhs-list-err-msg
Apr 6, 2019
Merged

better error msg when assign RHS is list column, closes #950#3457
mattdowle merged 4 commits intomasterfrom
assign-rhs-list-err-msg

Conversation

@jangorecki
Copy link
Copy Markdown
Member

closes #950

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 14, 2019

Codecov Report

Merging #3457 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3457   +/-   ##
=======================================
  Coverage   96.62%   96.62%           
=======================================
  Files          65       65           
  Lines       12255    12255           
=======================================
  Hits        11841    11841           
  Misses        414      414
Impacted Files Coverage Δ
src/assign.c 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e8db7c...03de5c1. Read the comment docs.

@mattdowle mattdowle added this to the 1.12.4 milestone Apr 3, 2019
@mattdowle mattdowle merged commit c88be48 into master Apr 6, 2019
@mattdowle mattdowle deleted the assign-rhs-list-err-msg branch April 6, 2019 22:18
@mattdowle mattdowle mentioned this pull request Apr 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DT assign by ref not accept list col as RHS, error msg misleading

2 participants