Skip to content

Better list assign#3504

Merged
mattdowle merged 17 commits intomasterfrom
better_list_assign
Apr 14, 2019
Merged

Better list assign#3504
mattdowle merged 17 commits intomasterfrom
better_list_assign

Conversation

@mattdowle
Copy link
Copy Markdown
Member

Follow up to #3457
Satisfies the original expectation in #950

@mattdowle mattdowle added this to the 1.12.4 milestone Apr 12, 2019
@mattdowle mattdowle requested a review from jangorecki April 12, 2019 03:11
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 12, 2019

Codecov Report

Merging #3504 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3504      +/-   ##
==========================================
+ Coverage   96.61%   96.62%   +<.01%     
==========================================
  Files          65       65              
  Lines       12255    12258       +3     
==========================================
+ Hits        11840    11844       +4     
+ Misses        415      414       -1
Impacted Files Coverage Δ
src/assign.c 100% <100%> (ø) ⬆️
src/uniqlist.c 96.68% <0%> (+0.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc7002b...dfb4243. Read the comment docs.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 12, 2019

Codecov Report

Merging #3504 into master will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3504      +/-   ##
==========================================
+ Coverage   96.61%   96.66%   +0.04%     
==========================================
  Files          65       65              
  Lines       12255    12280      +25     
==========================================
+ Hits        11840    11870      +30     
+ Misses        415      410       -5
Impacted Files Coverage Δ
src/fread.c 98.5% <100%> (ø) ⬆️
R/data.table.R 97.64% <100%> (ø) ⬆️
src/assign.c 100% <100%> (ø) ⬆️
src/uniqlist.c 98.98% <100%> (+2.85%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc7002b...edfdc46. Read the comment docs.

@mattdowle
Copy link
Copy Markdown
Member Author

mattdowle commented Apr 14, 2019

@MichaelChirico The merge from master looks odd in this PR. I either do a 'git merge master' locally and push, or a 'resolve conflicts' using the GitHub GUI. Both ways show as a single "Merge branch 'master' into better_list_assign" (theres a few above). But the latest merge master (that you did?) shows each commit to master separately (other PRs) and the 'files changed' tab doesn't match what I see locally; e.g. a binary file added in master from another PR is here in this PR but shows as a diff and there's no 'refresh' at the top so it's not that the diff tab hasn't updated yet.
I'll go ahead and merge. But for completeness just wondering what you did.

@mattdowle mattdowle merged commit bb1a824 into master Apr 14, 2019
@mattdowle mattdowle deleted the better_list_assign branch April 14, 2019 17:12
@MichaelChirico
Copy link
Copy Markdown
Member

on PR branch I ran git pull origin master, i thought it was the same as git merge master 🤔 will stick w the latter now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants