Skip to content

Improve handling NULL characters#3433

Merged
mattdowle merged 3 commits intoRdatatable:masterfrom
kiwiroy:issue-3400
Apr 12, 2019
Merged

Improve handling NULL characters#3433
mattdowle merged 3 commits intoRdatatable:masterfrom
kiwiroy:issue-3400

Conversation

@kiwiroy
Copy link
Copy Markdown
Member

@kiwiroy kiwiroy commented Feb 27, 2019

AFAICT the following is making for an "infinite" loop (nrowLimit is very large by default).

if (*tch=='\0') continue; // empty last line

Adding nrowLimit = myNrow to the branch appears to be a fix to force it to be the last line.

References

#3400

@kiwiroy kiwiroy force-pushed the issue-3400 branch 3 times, most recently from c773fb1 to 13d6df1 Compare February 27, 2019 21:59
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 27, 2019

Codecov Report

Merging #3433 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3433      +/-   ##
==========================================
+ Coverage   95.06%   95.06%   +<.01%     
==========================================
  Files          65       65              
  Lines       12249    12251       +2     
==========================================
+ Hits        11644    11646       +2     
  Misses        605      605
Impacted Files Coverage Δ
src/fread.c 98.34% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d4459d...193d224. Read the comment docs.

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 27, 2019

Codecov Report

Merging #3433 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3433      +/-   ##
==========================================
+ Coverage   96.65%   96.66%   +<.01%     
==========================================
  Files          65       65              
  Lines       12275    12277       +2     
==========================================
+ Hits        11865    11867       +2     
  Misses        410      410
Impacted Files Coverage Δ
src/fread.c 98.5% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b8fd62...751af17. Read the comment docs.

@mattdowle mattdowle added this to the 1.12.4 milestone Apr 12, 2019
@mattdowle
Copy link
Copy Markdown
Member

Thanks @kiwiroy! I've invited you to be project member.

@mattdowle mattdowle merged commit b84d0fe into Rdatatable:master Apr 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants