Improve handling NULL characters#3433
Merged
mattdowle merged 3 commits intoRdatatable:masterfrom Apr 12, 2019
Merged
Conversation
c773fb1 to
13d6df1
Compare
Codecov Report
@@ Coverage Diff @@
## master #3433 +/- ##
==========================================
+ Coverage 95.06% 95.06% +<.01%
==========================================
Files 65 65
Lines 12249 12251 +2
==========================================
+ Hits 11644 11646 +2
Misses 605 605
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #3433 +/- ##
==========================================
+ Coverage 96.65% 96.66% +<.01%
==========================================
Files 65 65
Lines 12275 12277 +2
==========================================
+ Hits 11865 11867 +2
Misses 410 410
Continue to review full report at Codecov.
|
Member
|
Thanks @kiwiroy! I've invited you to be project member. |
This was referenced Apr 12, 2019
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AFAICT the following is making for an "infinite" loop (nrowLimit is very large by default).
data.table/src/fread.c
Line 2151 in 0dfb91d
Adding
nrowLimit = myNrowto the branch appears to be a fix to force it to be the last line.References
#3400