Conversation
Codecov Report
@@ Coverage Diff @@
## master #3505 +/- ##
=======================================
Coverage 96.66% 96.66%
=======================================
Files 65 65
Lines 12277 12277
=======================================
Hits 11867 11867
Misses 410 410Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #3505 +/- ##
==========================================
- Coverage 96.66% 96.66% -0.01%
==========================================
Files 65 65
Lines 12280 12278 -2
==========================================
- Hits 11870 11868 -2
Misses 410 410
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #3433 for #3400
Closes #3400
Closes #2435
with warningand then proceeding as if the NUL wasn't there, which in this case would reading the extra line of data. Note the difference betweencatandmore: