Skip to content

fread nul in the middle of a field too#3514

Merged
mattdowle merged 6 commits intomasterfrom
freadNul
Apr 20, 2019
Merged

fread nul in the middle of a field too#3514
mattdowle merged 6 commits intomasterfrom
freadNul

Conversation

@mattdowle
Copy link
Copy Markdown
Member

@mattdowle mattdowle commented Apr 19, 2019

Follow up to #3505 and #3433 for #3400.
Thanks to a report and example file from Bingjie Qian received privately. (Name used with permission.)

@mattdowle mattdowle added this to the 1.12.4 milestone Apr 19, 2019
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 19, 2019

Codecov Report

Merging #3514 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3514      +/-   ##
==========================================
+ Coverage   96.72%   96.72%   +<.01%     
==========================================
  Files          66       66              
  Lines       12424    12437      +13     
==========================================
+ Hits        12017    12030      +13     
  Misses        407      407
Impacted Files Coverage Δ
src/freadR.c 96.28% <100%> (+0.12%) ⬆️
src/fread.c 98.49% <100%> (ø) ⬆️
src/nafill.c 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 280226b...195b775. Read the comment docs.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 19, 2019

Codecov Report

Merging #3514 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3514      +/-   ##
==========================================
+ Coverage   96.72%   96.72%   +<.01%     
==========================================
  Files          66       66              
  Lines       12424    12434      +10     
==========================================
+ Hits        12017    12027      +10     
  Misses        407      407
Impacted Files Coverage Δ
src/freadR.c 96.28% <100%> (+0.12%) ⬆️
src/fread.c 98.49% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 280226b...f4c8c03. Read the comment docs.

@mattdowle mattdowle merged commit b464e50 into master Apr 20, 2019
@mattdowle mattdowle deleted the freadNul branch April 20, 2019 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant