Skip to content

Fix for ‘column not found’ error in certain non-equi joins#3656

Merged
mattdowle merged 3 commits intomasterfrom
issue-3635-fix
Jul 9, 2019
Merged

Fix for ‘column not found’ error in certain non-equi joins#3656
mattdowle merged 3 commits intomasterfrom
issue-3635-fix

Conversation

@arunsrinivasan
Copy link
Copy Markdown
Member

@arunsrinivasan arunsrinivasan commented Jun 22, 2019

Closes #3635

@arunsrinivasan arunsrinivasan requested a review from mattdowle June 22, 2019 03:10
@mattdowle mattdowle added this to the 1.12.4 milestone Jul 9, 2019
@codecov
Copy link
Copy Markdown

codecov bot commented Jul 9, 2019

Codecov Report

Merging #3656 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3656   +/-   ##
=======================================
  Coverage   98.25%   98.25%           
=======================================
  Files          69       69           
  Lines       13088    13088           
=======================================
  Hits        12860    12860           
  Misses        228      228
Impacted Files Coverage Δ
R/data.table.R 97.87% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dbb0d0b...df51ecb. Read the comment docs.

1 similar comment
@codecov
Copy link
Copy Markdown

codecov bot commented Jul 9, 2019

Codecov Report

Merging #3656 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3656   +/-   ##
=======================================
  Coverage   98.25%   98.25%           
=======================================
  Files          69       69           
  Lines       13088    13088           
=======================================
  Hits        12860    12860           
  Misses        228      228
Impacted Files Coverage Δ
R/data.table.R 97.87% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dbb0d0b...df51ecb. Read the comment docs.

@mattdowle mattdowle merged commit 3d54417 into master Jul 9, 2019
@mattdowle mattdowle deleted the issue-3635-fix branch July 9, 2019 03:35
@UweBlock
Copy link
Copy Markdown
Contributor

It seems that this fix also closes #1989

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

non-equi join breaks inconsistently when using .SD

3 participants