Skip to content

fix autonaming issue in groupings sets for special symbols#3738

Merged
mattdowle merged 6 commits intomasterfrom
grouping-sets-jvars
Aug 24, 2019
Merged

fix autonaming issue in groupings sets for special symbols#3738
mattdowle merged 6 commits intomasterfrom
grouping-sets-jvars

Conversation

@jangorecki
Copy link
Copy Markdown
Member

closes #3653

@codecov
Copy link
Copy Markdown

codecov bot commented Aug 1, 2019

Codecov Report

Merging #3738 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3738      +/-   ##
==========================================
+ Coverage   98.81%   98.81%   +<.01%     
==========================================
  Files          69       69              
  Lines       13285    13292       +7     
==========================================
+ Hits        13127    13134       +7     
  Misses        158      158
Impacted Files Coverage Δ
R/groupingsets.R 96.87% <100%> (+0.24%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2986736...a4205e4. Read the comment docs.

@codecov
Copy link
Copy Markdown

codecov bot commented Aug 1, 2019

Codecov Report

Merging #3738 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3738      +/-   ##
==========================================
- Coverage   99.41%   99.41%   -0.01%     
==========================================
  Files          71       71              
  Lines       13216    13208       -8     
==========================================
- Hits        13139    13131       -8     
  Misses         77       77
Impacted Files Coverage Δ
R/groupingsets.R 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96be5a9...b8ad229. Read the comment docs.

@jangorecki
Copy link
Copy Markdown
Member Author

Code simplified, no need for workarounds because by=.() already works. Related #3270.

@jangorecki jangorecki changed the title fix autonaaming issue in groupings sets for special symbols fix autonaming issue in groupings sets for special symbols Aug 5, 2019
@mattdowle mattdowle added this to the 1.12.4 milestone Aug 24, 2019
@mattdowle mattdowle merged commit d959107 into master Aug 24, 2019
@mattdowle mattdowle deleted the grouping-sets-jvars branch August 24, 2019 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

groupingsets with autonamed j creates extra column for ungrouped set

2 participants