Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3925 +/- ##
=========================================
+ Coverage 99.4% 99.4% +<.01%
=========================================
Files 72 72
Lines 13547 13549 +2
=========================================
+ Hits 13466 13468 +2
Misses 81 81
Continue to review full report at Codecov.
|
jangorecki
approved these changes
Oct 1, 2019
Member
jangorecki
left a comment
jangorecki
left a comment
There was a problem hiding this comment.
Great to have this one in coming release!
…t(NULL) just as 1.12.2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3626
Also removed the list() wrapper that set() always added to avoid copies from before R 3.1. Each call would have been an allocation for the length-1 list wrapper there.
No changes to existing tests other than verbose output.
3 of 744 cran revdeps failed fail.log :
Tests in 1294.* that were error in dev, back to v1.12.2 behaviour which was to coerce list to atomic with warning.