Error handling for using a factor with i#4660
Closed
ben-schwen wants to merge 2 commits intoRdatatable:masterfrom
ben-schwen:master
Closed
Error handling for using a factor with i#4660ben-schwen wants to merge 2 commits intoRdatatable:masterfrom ben-schwen:master
i#4660ben-schwen wants to merge 2 commits intoRdatatable:masterfrom
ben-schwen:master
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4660 +/- ##
=======================================
Coverage 99.61% 99.61%
=======================================
Files 73 73
Lines 14244 14245 +1
=======================================
+ Hits 14189 14190 +1
Misses 55 55
Continue to review full report at Codecov.
|
Merged
Member
|
Replaced by #5120 which makes it work rather than a better error. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1632.
Added an additional check for
is.factorto avoid the confusing error "i has evaluated to type integer. Expecting logical, integer or double." when executingsetkey(data.table(a=factor("a")))[factor("a")].