Skip to content

DT[fctr] now works#5120

Merged
mattdowle merged 1 commit intomasterfrom
i-factor
Aug 30, 2021
Merged

DT[fctr] now works#5120
mattdowle merged 1 commit intomasterfrom
i-factor

Conversation

@mattdowle
Copy link
Copy Markdown
Member

Closes #1632
Supersedes #4660 (I was going to edit that PR as I usually do, but its branch was in a fork that no longer exists, plus the solution makes it work rather than make a better error, so I just did a new PR in the end.)

@mattdowle mattdowle added this to the 1.14.1 milestone Aug 30, 2021
@codecov
Copy link
Copy Markdown

codecov bot commented Aug 30, 2021

Codecov Report

Merging #5120 (35cfe3f) into master (42b492e) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 35cfe3f differs from pull request most recent head 8a1972d. Consider uploading reports for the commit 8a1972d to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5120   +/-   ##
=======================================
  Coverage   99.38%   99.38%           
=======================================
  Files          77       77           
  Lines       14506    14506           
=======================================
  Hits        14417    14417           
  Misses         89       89           
Impacted Files Coverage Δ
R/data.table.R 99.94% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42b492e...8a1972d. Read the comment docs.

@mattdowle mattdowle merged commit 9ec150a into master Aug 30, 2021
@mattdowle mattdowle deleted the i-factor branch August 30, 2021 22:36
@jangorecki jangorecki modified the milestones: 1.14.9, 1.15.0 Oct 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

handling i which is a factor

2 participants