Skip to content

CI improvements#4768

Merged
mattdowle merged 25 commits intomasterfrom
seei
Nov 3, 2020
Merged

CI improvements#4768
mattdowle merged 25 commits intomasterfrom
seei

Conversation

@jangorecki
Copy link
Copy Markdown
Member

@jangorecki jangorecki commented Oct 20, 2020

This PR does not

Both are blocked on GLCI ability to run multiple pipelines for same branch.

This PR

  • adds new Windows job "oldrel" that runs R 3.6, produce and publish binaries
  • prepare Check table to support proving information from scheduled jobs (different version, commit sha)
  • improves consistency to CRAN about quality/quantity of information provided (thanks @sindribaldur)
  • updates CI yaml for newer, more robust syntax

Also removes plm from our extended suggests other.Rraw as it require new OS dependency which we don't want, closes #4781.
Also closes #4780 by not publishing extended suggests package to final R repo on website.

@jangorecki jangorecki added the ci label Oct 20, 2020
@codecov
Copy link
Copy Markdown

codecov bot commented Oct 20, 2020

Codecov Report

Merging #4768 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4768   +/-   ##
=======================================
  Coverage   99.47%   99.47%           
=======================================
  Files          73       73           
  Lines       14556    14556           
=======================================
  Hits        14480    14480           
  Misses         76       76           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63632e6...f6affdd. Read the comment docs.

@jangorecki jangorecki added this to the 1.13.3 milestone Oct 21, 2020
Comment thread .ci/publish.R
Comment thread .ci/publish.R
Comment thread .ci/publish.R
Comment thread inst/tests/other.Rraw
@mattdowle
Copy link
Copy Markdown
Member

Have seen the failed appveyor-devel job is due to the -alike change in latest R-devel, which is fixed in master by #4770. So proceeding to merge.

@mattdowle mattdowle merged commit 1ab3d58 into master Nov 3, 2020
@mattdowle mattdowle deleted the seei branch November 3, 2020 02:57
@jangorecki
Copy link
Copy Markdown
Member Author

New syntax for defining dependencies introduced in this PR gave us new DAG graph: https://gitlab.com/Rdatatable/data.table/-/pipelines/210901332/dag
That more precisely visualize dependencies between jobs.
It also let us to download a little less artifacts between different jobs. For deploy docker build jobs we didn't need website artifacts from integration stage but we do still need to wait for this stage to finish.

@jangorecki
Copy link
Copy Markdown
Member Author

Another nice thing is that check summary table provides now more details:
https://rdatatable.gitlab.io/data.table/web/checks/check_results_data.table.html

@AdrianAntico
Copy link
Copy Markdown

@jangorecki

Hey guys, not sure if this recent update is causing the warning below or if my machine is acting weird. Nonetheless, I started receiving a warning today when running library(data.table). Code info is below:

> library(data.table)
data.table 1.13.2 using 32 threads (see ?getDTthreads).  Latest news: r-datatable.com
Warning message:
package ‘data.table’ was built under R version 4.0.3

> sessionInfo()
R version 4.0.2 (2020-06-22)
Platform: x86_64-w64-mingw32/x64 (64-bit)
Running under: Windows 10 x64 (build 18363)

Matrix products: default

locale:
[1] LC_COLLATE=English_United States.1252  LC_CTYPE=English_United States.1252   
[3] LC_MONETARY=English_United States.1252 LC_NUMERIC=C                          
[5] LC_TIME=English_United States.1252    

attached base packages:
[1] stats     graphics  grDevices utils     datasets  methods   base     

other attached packages:
[1] data.table_1.13.2

loaded via a namespace (and not attached):
[1] compiler_4.0.2 tools_4.0.2   

@jangorecki
Copy link
Copy Markdown
Member Author

jangorecki commented Nov 4, 2020

@AdrianAntico This upgrade is not a cause of warning you are getting.
First of all you are using 1.13.2 which must have been installed from CRAN therefore nothing related to our CI pipeline which releases only odd version numbers.
AFAIU warning is caused by the fact that CRAN ships data.table built on r-release (4.0.3) and you use previous version 4.0.2. If you want to get rid of the warning, I think install.packages("data.table", type="source") should be sufficient. Alternatively you can also upgrade your R version to 4.0.3, that will also resolve the warning.

@AdrianAntico
Copy link
Copy Markdown

@jangorecki Thanks for getting back to me. I just reinstalled with type="source" and I'm no longer seeing the warning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove plm tests from other.Rraw DT devel R package repo should not include non-dependencies packages

4 participants