Skip to content

update unit test err msg, closes #4769#4770

Merged
mattdowle merged 2 commits intomasterfrom
r-devel-errmsg
Oct 31, 2020
Merged

update unit test err msg, closes #4769#4770
mattdowle merged 2 commits intomasterfrom
r-devel-errmsg

Conversation

@jangorecki
Copy link
Copy Markdown
Member

@jangorecki jangorecki commented Oct 21, 2020

closes #4769
passed on 2020-10-20 r79356 https://gitlab.com/jangorecki/data.table/-/jobs/803180097
R change 2020-10-20 r79353

@jangorecki jangorecki added this to the 1.13.3 milestone Oct 21, 2020
@codecov
Copy link
Copy Markdown

codecov bot commented Oct 21, 2020

Codecov Report

Merging #4770 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4770   +/-   ##
=======================================
  Coverage   99.47%   99.47%           
=======================================
  Files          73       73           
  Lines       14556    14556           
=======================================
  Hits        14480    14480           
  Misses         76       76           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63632e6...3096095. Read the comment docs.

@mattdowle
Copy link
Copy Markdown
Member

I changed the pattern to be minimal in case of any similar minor changes to R's message in future. We should probably review all tests that look for R's messages, and similarly relax them. Not sure how to find them though.

For the news item, I took it as an opportunity to give credit to CRAN.

@MichaelChirico
Copy link
Copy Markdown
Member

Not sure how to find them though.

suggestion -- run an R session in chinese & run tests. i think you'll need to tweak test.data.table() since we made that change for non-english sessions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

R-devel changed error message breaks 1199.2

3 participants