Skip to content

Only warn once about '...' contents in merge.data.table#7091

Merged
MichaelChirico merged 11 commits intomasterfrom
merge-on
Jun 24, 2025
Merged

Only warn once about '...' contents in merge.data.table#7091
MichaelChirico merged 11 commits intomasterfrom
merge-on

Conversation

@MichaelChirico
Copy link
Copy Markdown
Member

Step one towards #7088.

First I want to unify warning handling -- it doesn't make sense to throw potentially dozens of warnings for the same fundamental issue (ignored arguments in ...).

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 24, 2025

  • HEAD=merge-on slower P<0.001 for memrecycle regression fixed in #5463
    Comparison Plot

Generated via commit 6913d5c

Download link for the artifact containing the test results: ↓ atime-results.zip

Task Duration
R setup and installing dependencies 2 minutes and 37 seconds
Installing different package versions 19 seconds
Running and plotting the test cases 2 minutes and 34 seconds

@MichaelChirico MichaelChirico requested a review from aitap June 24, 2025 16:19
@MichaelChirico
Copy link
Copy Markdown
Member Author

Looping in @aitap for internationalization -- I'm cognizant of issues with nesting (e.g. https://stackoverflow.com/q/1888487/3576984). How foolhardy is the subclause approach here? I couldn't quickly think of a way to simplify this to only use 1 (or 0) ngettext() calls.

(not a blocker for this PR, let's handle as a follow-up as needed)

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.69%. Comparing base (3b00b35) to head (6913d5c).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7091   +/-   ##
=======================================
  Coverage   98.69%   98.69%           
=======================================
  Files          79       79           
  Lines       14677    14688   +11     
=======================================
+ Hits        14486    14497   +11     
  Misses        191      191           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@MichaelChirico MichaelChirico merged commit 495ffd4 into master Jun 24, 2025
11 checks passed
@MichaelChirico MichaelChirico deleted the merge-on branch June 24, 2025 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants