Only warn once about '...' contents in merge.data.table#7091
Merged
MichaelChirico merged 11 commits intomasterfrom Jun 24, 2025
Merged
Only warn once about '...' contents in merge.data.table#7091MichaelChirico merged 11 commits intomasterfrom
MichaelChirico merged 11 commits intomasterfrom
Conversation
jangorecki
approved these changes
Jun 24, 2025
|
Generated via commit 6913d5c Download link for the artifact containing the test results: ↓ atime-results.zip
|
Member
Author
|
Looping in @aitap for internationalization -- I'm cognizant of issues with nesting (e.g. https://stackoverflow.com/q/1888487/3576984). How foolhardy is the subclause approach here? I couldn't quickly think of a way to simplify this to only use 1 (or 0) (not a blocker for this PR, let's handle as a follow-up as needed) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7091 +/- ##
=======================================
Coverage 98.69% 98.69%
=======================================
Files 79 79
Lines 14677 14688 +11
=======================================
+ Hits 14486 14497 +11
Misses 191 191 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Step one towards #7088.
First I want to unify warning handling -- it doesn't make sense to throw potentially dozens of warnings for the same fundamental issue (ignored arguments in
...).