Use faster base implementation for isoweek#7144
Merged
MichaelChirico merged 2 commits intomasterfrom Jul 10, 2025
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7144 +/- ##
==========================================
- Coverage 98.50% 98.50% -0.01%
==========================================
Files 81 81
Lines 15015 15014 -1
==========================================
- Hits 14791 14790 -1
Misses 224 224 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
No obvious timing issues in HEAD=isoweek-fast Generated via commit 1afb359 Download link for the artifact containing the test results: ↓ atime-results.zip
|
Member
|
LGTM, I only question if we should also add Since |
Closed
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Closes #5111.
Matt's comment about trying to make
isoweek()even faster than the base implementation is nice, but in the meantime, we shouldn't miss out on the 20x speed-up.I'm fairly confident #3279 will help a lot in this case -- the slowest step in the
masterimplementation is converting all the Jan. 1 in the input from character withas.IDate(). Presumably there will only be a few unique Jan. 1 in the input, meaning we only really need to convert a few unique dates with the slowstrptime()path.But anyway, that can be done later for a second, further speed-up.