add french version of datatable-joins.Rmd#7151
Conversation
aligned on last version of June23, 2025 data.table/vignettes/datatable-joins.Rmd
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7151 +/- ##
==========================================
+ Coverage 98.50% 98.77% +0.26%
==========================================
Files 81 81
Lines 15019 15185 +166
==========================================
+ Hits 14795 14999 +204
+ Misses 224 186 -38 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
MichaelChirico
left a comment
There was a problem hiding this comment.
Magnifique!! Merci beaucoup!
(I will leave it pending for now in case any other reviewer wants to weigh in on the actual translation)
|
About how to do relative linking... I see only this in Russian: data.table/vignettes/ru/datatable-intro.Rmd Line 147 in 8b1e3f9 I confirmed that link WAI on the rendered version: https://rdatatable.gitlab.io/data.table/articles/ru/datatable-intro.html |
emaigne
left a comment
There was a problem hiding this comment.
thanks @ChristianWia for the translation. I put some comments and propositions of rephrasing.
corrected: remark taken into account L 89-92 monday friday....
corrected relative path to _translation_links.R
|
|
I know we need the ',' in litedown, it's maybe optional in knitr? |
corrected lines 684 653 576 448 446 275 216 184 173
rereading lines 576 101
Next week i will try this form on my desktop with litedown and knitr to see if we are still compliant. results attached to => #6583 |
rereading
FR related vignettes are supposed to be accessed in the same directory
|
@tdhock I will let you merge when you are ready |
|
I did a local render and it looks good, thanks very much! |
aligned on last version of June23, 2025 data.table/vignettes/datatable-joins.Rmd