Improve description of nan= and fill= in ?nafill, include example#7186
Merged
jangorecki merged 3 commits intomasterfrom Aug 30, 2025
Merged
Improve description of nan= and fill= in ?nafill, include example#7186jangorecki merged 3 commits intomasterfrom
jangorecki merged 3 commits intomasterfrom
Conversation
MichaelChirico
commented
Jul 17, 2025
MichaelChirico
commented
Jul 17, 2025
MichaelChirico
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7186 +/- ##
=======================================
Coverage 98.77% 98.77%
=======================================
Files 81 81
Lines 15203 15203
=======================================
Hits 15017 15017
Misses 186 186 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
MichaelChirico
added a commit
that referenced
this pull request
Jul 18, 2025
MichaelChirico
added a commit
that referenced
this pull request
Jul 21, 2025
* added nan parameter to fcoalesce * Style, link ?nafill * incorporate #7186 insights here too * duplicate loop for NA and NAN arg * tests * added tests for use of vector replacement also * added news entry --------- Co-authored-by: Michael Chirico <chiricom@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also be more intentional about using "double" (storage type) vs. "numeric" (more ambiguous term in R, but generally "the
mode()of integer or double vectors)