[SVS] Add unit test to validate the compute distance fix #858
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meiravgri
added a commit
that referenced
this pull request
Dec 10, 2025
rfsaliev
commented
Dec 11, 2025
rfsaliev
force-pushed
the
rfsaliev/test-svs-distance
branch
from
79b8abd to
5128cf4
Compare
rfsaliev
changed the title
rfsaliev
force-pushed
the
rfsaliev/test-svs-distance
branch
from
f5d85b9 to
a70e36d
Compare
rfsaliev
changed the title
Collaborator
Author
|
It seems like here is duplication with #865... |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #858 +/- ##
==========================================
- Coverage 97.06% 97.04% -0.03%
==========================================
Files 126 126
Lines 7403 7403
==========================================
- Hits 7186 7184 -2
- Misses 217 219 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
* Use system page protection to catch the unmasked vector loading issue * Do not use pre-compiled SVS binaries but compile from sources * Update SVS submodule to the latest main with AVX2 fixes
rfsaliev
force-pushed
the
rfsaliev/test-svs-distance
branch
from
a70e36d to
0608bd4
Compare
rfsaliev
changed the title
meiravgri
reviewed
Dec 18, 2025
tests/unit/test_svs.cpp
Outdated
| auto dist_ip = svs::distance::compute(svs::DistanceIP{}, std::span(a, dim), std::span(b, dim)); | ||
| EXPECT_GT(dist_ip, 0.0); | ||
|
|
||
| #ifdef __x86_64__ |
Collaborator
There was a problem hiding this comment.
Is there any value in running this test on non x86_64 platforms?
Collaborator
There was a problem hiding this comment.
so lets move it to guard the entire test
Collaborator
Author
There was a problem hiding this comment.
I mean explicit calls to AVX2 and AVX512 optimizations make no sense on non-x86 platforms.
meiravgri
approved these changes
Dec 18, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-actions bot
pushed a commit
that referenced
this pull request
Dec 18, 2025
* Add test with direct call to SVS distance computations * Use system page protection to catch the unmasked vector loading issue * Do not use pre-compiled SVS binaries but compile from sources * Update SVS submodule to the latest main with AVX2 fixes * Address code review comment (cherry picked from commit e493894)
|
Successfully created backport PR for |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 18, 2025
[SVS] Add unit test to validate the compute distance fix (#858) * Add test with direct call to SVS distance computations * Use system page protection to catch the unmasked vector loading issue * Do not use pre-compiled SVS binaries but compile from sources * Update SVS submodule to the latest main with AVX2 fixes * Address code review comment (cherry picked from commit e493894) Co-authored-by: Rafik Saliev <rafik.f.saliev@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the Scalable Vector Search (SVS) integration by upgrading the SVS submodule and all related prebuilt library URLs to version 0.1.0. It also introduces a new unit test to verify the correctness and safety of SVS distance computations, especially with regard to memory alignment and hardware-accelerated implementations.
SVS version upgrade and integration:
ScalableVectorSearchsubmodule to the latest commit, bringing in the newest SVS features and fixes.cmake/svs.cmakefrom version 0.0.11 to 0.1.0, ensuring the project uses the latest SVS release for both Clang and GCC toolchains, and for all supported GLIBC versions.Testing and validation improvements:
compute_distanceintest_svs.cppto validate SVS distance computation functions. The test checks for correct handling of custom memory alignment using system page boundaries and verifies that hardware-optimized (AVX2/AVX512) and default implementations produce identical results.Which issues this PR fixes
Main objects this PR modified
Mark if applicable