Skip to content

Conversation

@github-actions
Copy link

Description

Backport of #858 to 8.2.

* Add test with direct call to SVS distance computations

* Use system page protection to catch the unmasked vector loading issue
* Do not use pre-compiled SVS binaries but compile from sources
* Update SVS submodule to the latest main with AVX2 fixes

* Address code review comment

(cherry picked from commit e493894)
@GuyAv46 GuyAv46 marked this pull request as draft December 18, 2025 14:18
@GuyAv46 GuyAv46 marked this pull request as ready for review December 18, 2025 14:18
@GuyAv46 GuyAv46 requested a review from rfsaliev December 18, 2025 14:19
@meiravgri meiravgri enabled auto-merge December 18, 2025 14:23
@codecov
Copy link

codecov bot commented Dec 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.00%. Comparing base (5afb165) to head (fc959d0).
⚠️ Report is 1 commits behind head on 8.2.

Additional details and impacted files
@@            Coverage Diff             @@
##              8.2     #870      +/-   ##
==========================================
+ Coverage   96.96%   97.00%   +0.04%     
==========================================
  Files         126      126              
  Lines        7353     7353              
==========================================
+ Hits         7130     7133       +3     
+ Misses        223      220       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@meiravgri meiravgri added this pull request to the merge queue Dec 18, 2025
Merged via the queue into 8.2 with commit c801d8a Dec 18, 2025
15 checks passed
@meiravgri meiravgri deleted the backport-858-to-8.2 branch December 18, 2025 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants