Skip to content

fix: improve hover text 'unknown' for better UX. #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MantisClone merged 4 commits into from
Jan 16, 2023
Merged

fix: improve hover text 'unknown' for better UX. #47

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a139d3a
Fix: improve hover text 'unknown' for better UX.
PijiDev Jan 2, 2023
eebf55e
Revert - change doesn't build
PijiDev Jan 2, 2023
ae01c29
Fix all 'unknown' strings, succesful build
PijiDev Jan 3, 2023
e97df4a
Fix: Change string
PijiDev Jan 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/pay/src/components/PaymentActions.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,7 +295,7 @@ const PaymentActions = () => {
!paymentReady ||
!!error ||
!!paymentError ||
request.status === "unknown"
request.status === "waiting"
}
/>
);
Expand Down
6 changes: 3 additions & 3 deletions packages/request-ui/src/RStatusBadge.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ export const statusLabels: Record<RequestStatus, string> = {
pending: 'Pending',
canceled: 'Canceled',
overpaid: 'Overpaid',
unknown: 'Unknown',
waiting: 'Creating Request'
};

export const RStatusBadge = (props: IProps) => {
Expand All @@ -40,8 +40,8 @@ export const RStatusBadge = (props: IProps) => {
<div
className={[classes.status, props.className].join(' ')}
title={
props.status === 'unknown'
? 'The balance computation might have failed'
props.status === 'waiting'
? 'Waiting for request to be stored in IPFS'
: ''
}
>
Expand Down
2 changes: 1 addition & 1 deletion packages/request-ui/src/colors.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ export const statusColors: Record<RequestStatus, string> = {
pending: '#CBBEFF',
canceled: '#FFBEBE',
overpaid: '#BEE8FF',
unknown: '#D3D3D3',
waiting: '#D3D3D3',
};

export const alertColors = {
Expand Down
2 changes: 1 addition & 1 deletion packages/shared/src/helpers/parseRequest.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ const getStatus = (
balance: BigNumber | undefined,
pending: boolean
) => {
if (!balance) return "unknown";
if (!balance) return "waiting";
if (state === Types.RequestLogic.STATE.CANCELED) return "canceled";

if (balance?.eq(expectedAmount)) return "paid";
Expand Down
2 changes: 1 addition & 1 deletion packages/shared/src/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ export type RequestStatus =
| "pending"
| "canceled"
| "overpaid"
| "unknown";
| "waiting";

/** Formatted request */
export interface IParsedRequest {
Expand Down
Loading