refactor: remove axios #1237

benjlevesque · 2023-11-13T18:03:12Z

Motivation

reduce size (minor impact)
avoid versions conflicts
reduce maintenance

Changing to MSW for mocks also has the benefit to be compatible with any client.

Choices

Dropping gas-price-definer. This is never used, since feat!: drop legacy storage #1117
dropping IpfsStore.read. This is never used.
remove maxSize from IpfsManager.read. This method is kept as a convenience, as it's useful to test the read after upload, but is no longer used (since feat!: drop legacy storage #1117).
axios remains a devDependency of smart-contracts and toolbox for now

packages/request-node/src/request/getChannelsByTopic.ts

packages/request-node/src/request/persistTransaction.ts

benjlevesque · 2023-11-13T18:32:40Z

packages/request-node/test/persistTransaction.test.ts

      .expect(StatusCodes.INTERNAL_SERVER_ERROR);
  });
-
-  it('should catch IPFS timeout error', async () => {


I decided to remove this test. it's a bit hard to replicate and I feel it has no real value

I disagree with this. The Request Node still writes to IPFS but it should fail gracefully if for some reason that write fails.

packages/ethereum-storage/test/ipfs-manager.test.ts

benjlevesque · 2023-11-16T14:15:22Z

packages/request-client.js/test/index.test.ts

-        expect(config.headers[httpConfigDefaults.requestClientVersionHeader]).toBe(
-          packageJson.version,
-        );


I ditched that test, I don't really see the intention

packages/request-client.js/test/index.test.ts

coveralls · 2024-01-17T15:39:39Z

coverage: 86.667% (-0.5%) from 87.128%
when pulling 8e03773 on refactor/remove-axios
into 45d1f5b on master.

yomarion

Nice

yomarion · 2024-01-17T16:37:44Z

FYI @benjlevesque, the yarn.lock file still references axios@0.27.2 that looks unused.

benjlevesque · 2024-01-17T16:56:47Z

@yomarion

axios remains a devDependency of smart-contracts and toolbox for now

alexandre-abrioux

nice! ✨

alexandre-abrioux · 2024-01-17T16:59:24Z

packages/request-client.js/test/index.test.ts

+      mockServer.close();
+    });

+    it('specify the Request Client version in the header', async () => {


I couldn't find where we assert in this test that the client version is passed down in the headers. Is the test name wrong, or is this assertion missing?

What was the conclusion here?

I think it was a typo and it was renamed back to the original name. cc @benjlevesque can you confirm?

yes, sorry my comment remained "pending":

good catch. Probably a bad merge or copy paste, I removed that test

but in the meantime I also added back a check on the version header

packages/request-client.js/test/index.test.ts

benjlevesque changed the title ~~refactor/remove axios~~ build(deps): Bump axios from 0.27.2 to 1.6.0 refactor: remove axios Nov 13, 2023

benjlevesque changed the title ~~build(deps): Bump axios from 0.27.2 to 1.6.0 refactor: remove axios~~ refactor: remove axios Nov 13, 2023

benjlevesque force-pushed the refactor/remove-axios branch from 7d3a5c5 to 7a1f63e Compare November 13, 2023 18:25

benjlevesque commented Nov 13, 2023

View reviewed changes

packages/request-node/src/request/getChannelsByTopic.ts Outdated Show resolved Hide resolved

benjlevesque commented Nov 13, 2023

View reviewed changes

packages/request-node/src/request/persistTransaction.ts Outdated Show resolved Hide resolved

benjlevesque commented Nov 13, 2023

View reviewed changes

benjlevesque commented Nov 16, 2023

View reviewed changes

packages/request-client.js/test/index.test.ts Outdated Show resolved Hide resolved

MantisClone mentioned this pull request Nov 16, 2023

build(deps): Bump axios from 0.27.2 to 1.6.0 #1235

Closed

benjlevesque force-pushed the refactor/remove-axios branch from c33e957 to 0def2ba Compare November 28, 2023 16:17

benjlevesque changed the base branch from master to test/reduce-flaky-tests November 28, 2023 16:17

benjlevesque force-pushed the test/reduce-flaky-tests branch from d30f9c0 to d27db26 Compare November 29, 2023 10:10

benjlevesque force-pushed the test/reduce-flaky-tests branch from 9dec3a3 to a2642ac Compare December 19, 2023 11:22

Base automatically changed from test/reduce-flaky-tests to master December 19, 2023 11:29

benjlevesque force-pushed the refactor/remove-axios branch from 0def2ba to b7df198 Compare January 17, 2024 14:42

benjlevesque marked this pull request as ready for review January 17, 2024 15:40

benjlevesque requested review from KolevDarko, MantisClone, alexandre-abrioux, leoslr and yomarion January 17, 2024 15:40

github-actions bot requested review from kevindavee and olivier7delf January 17, 2024 15:40

yomarion approved these changes Jan 17, 2024

View reviewed changes

alexandre-abrioux approved these changes Jan 17, 2024

View reviewed changes

benjlevesque enabled auto-merge (squash) January 18, 2024 10:12

refactor: remove axios

929bd17

benjlevesque added 12 commits January 18, 2024 11:12

Apply suggestions from code review

68569e0

Apply suggestions from code review

7cfe88f

toolbox

a7a53e6

lint

b4f4fb4

fix mocks

58537bd

fix object in searchparams

15b1ba7

Update packages/request-client.js/test/index.test.ts

0d33d48

cleanup

ca55ea5

debug

520fcd0

debug2

502b781

fix count calls (ignore localhost:3000)

255780c

fix header version test

8e03773

benjlevesque force-pushed the refactor/remove-axios branch from d68636a to 8e03773 Compare January 18, 2024 10:12

benjlevesque merged commit 2e2bcfa into master Jan 18, 2024

benjlevesque deleted the refactor/remove-axios branch January 18, 2024 10:18

benjlevesque mentioned this pull request Jan 19, 2024

chore(cd): fix clean script for cd #1338

Merged

MantisClone mentioned this pull request Jan 30, 2024

feat(request-node): nodejs 18.19 alpine 3.19 RequestNetwork/docker-images#21

Merged

MantisClone mentioned this pull request Jul 17, 2024

feat: Create new data access to allow for in-memory transactions. #1386

Merged

refactor: remove axios #1237

refactor: remove axios #1237

Uh oh!

Conversation

benjlevesque commented Nov 13, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Motivation

Choices

Uh oh!

Uh oh!

Uh oh!

benjlevesque Nov 13, 2023

Choose a reason for hiding this comment

Uh oh!

MantisClone Jan 19, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

benjlevesque Nov 16, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

coveralls commented Jan 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

yomarion left a comment

Choose a reason for hiding this comment

Uh oh!

yomarion commented Jan 17, 2024

Uh oh!

benjlevesque commented Jan 17, 2024

Uh oh!

alexandre-abrioux left a comment

Choose a reason for hiding this comment

Uh oh!

alexandre-abrioux Jan 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

MantisClone Jan 19, 2024

Choose a reason for hiding this comment

Uh oh!

alexandre-abrioux Jan 19, 2024

Choose a reason for hiding this comment

Uh oh!

benjlevesque Jan 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

benjlevesque commented Nov 13, 2023 •

edited

Loading

coveralls commented Jan 17, 2024 •

edited

Loading

alexandre-abrioux Jan 17, 2024 •

edited

Loading

benjlevesque Jan 22, 2024 •

edited

Loading