Skip to content

chore(cd): fix clean script for cd#1338

Merged
yomarion merged 5 commits intomasterfrom
chore-cd/fix-clean-for-cd
Jan 19, 2024
Merged

chore(cd): fix clean script for cd#1338
yomarion merged 5 commits intomasterfrom
chore-cd/fix-clean-for-cd

Conversation

@yomarion
Copy link
Contributor

@yomarion yomarion commented Jan 19, 2024

Description of the changes

This fixes the issue introduced by #1328 , when running next-release as part of the CI.

Partial view of the problem:

> @requestnetwork/data-format:clean

$ shx rm -rf dist tsconfig.tsbuildinfo tsconfig.build.tsbuildinfo
rm: no such file or directory: tsconfig.tsbuildinfo

@yomarion yomarion requested a review from benjlevesque January 19, 2024 09:40
@yomarion yomarion marked this pull request as ready for review January 19, 2024 09:42
@yomarion yomarion merged commit bd20408 into master Jan 19, 2024
@yomarion yomarion deleted the chore-cd/fix-clean-for-cd branch January 19, 2024 10:25
@benjlevesque
Copy link
Contributor

I don't think the issue comes from #1328, but from #1237

@benjlevesque
Copy link
Contributor

still not 😅
actually #1333

@yomarion
Copy link
Contributor Author

still not 😅 actually #1333

@benjlevesque of course! The previous one failed to build so it's a different issue. I was looking for the lerna change from previous commits but it's not in the name. Thanks.

@benjlevesque
Copy link
Contributor

what's strange is that the file missing is in data-format, which is a good argument for #1328, but the build and released worked

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants