Center single invoice modal

[sstefdev]

Fixes #164

Problem

The Invoice View Modal is currently off-center, leading to a suboptimal user experience. While originally planned as a drawer, the modal was implemented as a simpler solution, but it now requires alignment adjustments.

Changes

• Updated styles to center the Invoice View Modal (Drawer) within the viewport.

Summary by CodeRabbit

• New Features

  • Improved styling and positioning of the drawer overlay for better user experience.
  • Enhanced responsiveness with adjustments for smaller screens.

• Bug Fixes

  • Fixed positioning issues to ensure the drawer is centered in the viewport.

• Style

  • Updated background color and transition effects for smoother animations.

[coderabbitai]

Walkthrough

The changes in this pull request focus on the drawer.svelte component within the invoice dashboard. Key modifications include updating the overlay class name from "active" to "active-overlay" and altering its background color. The drawer's positioning has been changed from absolute to fixed, centering it in the viewport. A media query adjusts the positioning for smaller screens. The transition effects remain unchanged, ensuring smooth animations during state changes.

Changes

File Path	Change Summary
packages/invoice-dashboard/src/lib/dashboard/drawer.svelte	- Changed overlay class from "active" to "active-overlay". - Updated overlay background color to transparent. - Changed drawer positioning from absolute to fixed, centering it in the viewport. - Modified transform for active state to translate(-50%, -50%). - Added media query for screens < 880px to adjust drawer position to absolute.

Possibly related issues

• Center the Invoice View Modal on the Invoice Dashboard #164: The changes address the issue of centering the Invoice View Modal, which is similar to the drawer's new centering behavior.

Possibly related PRs

• fix: drawer close when clicked outside #81: This PR modifies the drawer.svelte component by adding a new drawer-overlay element, which is directly related to the changes made in the main PR regarding the overlay's class name and styling.
• Added tooltip and changed decimal point on amount #194: This PR involves the view-requests.svelte file within the same invoice dashboard context, indicating a potential connection in terms of overall UI improvements.

Suggested reviewers

• rodrigopavezi
• MantisClone
• aimensahnoun

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

🧹 Outside diff range and nitpick comments (2)

packages/invoice-dashboard/src/lib/dashboard/drawer.svelte (2)

48-54: LGTM! Proper implementation of modal centering

The positioning implementation follows best practices for centering modals. Consider adding transform to the transition property to ensure smooth animation during opening/closing.

-    transition: all 300ms;
+    transition: all 300ms, transform 300ms;

Also applies to: 104-105

---

Line range hint 1-120: Consider renaming and restructuring the component

The component has evolved from a drawer to a modal, but its name and some structural elements still reflect the drawer pattern. Consider:

1. Renaming the component to Modal.svelte or InvoiceModal.svelte
2. Updating class names from drawer to modal
3. Creating separate components for drawer and modal patterns if both are needed

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between ca33fb9 and 0860a96.

📒 Files selected for processing (1)

• packages/invoice-dashboard/src/lib/dashboard/drawer.svelte (4 hunks)

🔇 Additional comments (1)

packages/invoice-dashboard/src/lib/dashboard/drawer.svelte (1)

11-11: LGTM! Good separation of overlay and drawer styles

The separation of overlay styles into a dedicated class improves code organization and maintainability.

Also applies to: 31-31, 113-114