Feature/client local bind#22
Closed
JChrist wants to merge 45 commits into
Closed
Conversation
add support for missing pdu's and tags
Allowing unbound channel to respond to enquire_link PDU
Corrected name of DataCoding 0x01 in SmppConstants to IA5 (not GSM)
Add ESM_CLASS Message Mode constants
…r_fix DefaultSmppServer should use IO executor passed to its constructor
It looks like these were extracted from Table 5-2 of the SMPP Protocol Specification v3.4 using some sort of script / automation, and that extraction got messed up from the `STATUS_INVCMDID` constant onwards, such that thereafter the constants' comments were placed _after_ the constant, not before. This change simply moves the relevant constants to their correct location, _before_ their relevant constants, consistent with the class' other constants. The diff is a bit messy, which can't be helped, but the constants themselves (names and values) are not changed. For interest, the broken layout existed in the very first commit of the `SmppConstants.java` file (e6965ae) which was an "initial export of svn repo for public release".
Fix-up comments on the SMPP error code constants
Prep for new release
Set the openjdk version to 7 for travis
# Conflicts: # CHANGELOG.md # pom.xml # src/main/java/com/cloudhopper/smpp/impl/DefaultSmppServer.java # src/main/java/com/cloudhopper/smpp/transcoder/DefaultPduTranscoder.java # src/test/java/com/cloudhopper/smpp/transcoder/PduDecoderTest.java # src/test/java/com/cloudhopper/smpp/transcoder/PduEncoderTest.java
…brought from master to netty 4 ByteBuf
Netty4 merged with master (plus updates)
# Conflicts: # README.md # pom.xml # src/main/java/com/cloudhopper/smpp/transcoder/DefaultPduTranscoder.java
…ing) parameter (no method cancel without parameters exists)
…n, offering the option to configure the *client* to bind to specific host and port when trying to connect to a server
…e was protected) which receives clientBindHost and clientBindPort extra parameters, which in case that clientBindHost is not null are used for configuring the clientBootstrap to bind to a specific local address (otherwise a null InetSocketAddress is used, as per the default)
…hat there's no need to have a try/finally block in each test. added tests for ensuring that a client can bind to a specific local address (host and maybe also port). For the test that checks that a client is bound to a specific port as well, a port is chosen at random. However, it is again checked that if a BindException occurs due to trying to bind to a port that was already in use earlier, the test is ignored (with junit's Assume), rather than failing, since there's not much to do for tcp connections in TIME_WAIT state.
…st supported java version (1.5 is not supported due to several @OverRide in classes implementing interface methods)
|
@JChrist would you please consider splitting this PR into two (or more) for each of the different changes you've made here? while this may be a desirable feature (especially if it doesn't break backwards-compatibility, which, btw, is hard to tell from a quick look at this PR) and we might want to merge that in, the extra changes you're introducing are really pushing back the chances of this getting properly reviewed some time soon. In any case, thanks for your time and effort! |
|
@JChrist any chance you have some time to come round to this ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains several changes:
clientBindHostandclientBindPortoptions inSmppConnectionConfiguration, for configuring a client to bind to a specific local address when attempting to connect to a server.