Skip to content

Add a text box to let user insert pixel per inch#13

Closed
pci06 wants to merge 1 commit intoRobbbb:masterfrom
pci06:ppInch
Closed

Add a text box to let user insert pixel per inch#13
pci06 wants to merge 1 commit intoRobbbb:masterfrom
pci06:ppInch

Conversation

@pci06
Copy link

@pci06 pci06 commented Jun 10, 2021

Hello,
On computer with 96 DPI, the 72 DPI default gives wrong millimeter width.
pci.

@Robbbb
Copy link
Owner

Robbbb commented Jun 11, 2021

Hi Pci!

Thanks for the work you put into this!
Is it live somewhere for me to test out before merging?
I think that this has the potential to be very helpful, but also it has the potential to confuse users.
Can you tell me the steps to reproduce the bug? Was the SVG the wrong scale on your screen? When printed? In vector software?

Ideally we would use the actual units we are building a ruler with, mm for mm, inches for inches.
SVG has support for units, but I am not sure Paper.JS does.

looking forward to hearing more!

@Robbbb
Copy link
Owner

Robbbb commented Sep 18, 2021

Hey @pci06 !
I am open to merging this, but still confused about what software the DPI issue was causing issues in.

@darigovresearch
Copy link
Collaborator

@pci06 thanks for the pull request, are you able to generate a GitHub page of your fork so the feature can be tested?

Could you please also advise to help clarify the confusion with @Robbbb ?

@Robbbb
Copy link
Owner

Robbbb commented Sep 28, 2021

Also note this pull would revert the SVG export code to the broken version, preventing export.

@Robbbb Robbbb mentioned this pull request Jul 24, 2022
@Robbbb
Copy link
Owner

Robbbb commented Jul 24, 2022

I merged it with copy and paste because I don't know how to use github. Thanks @pci06 !!!

@Robbbb Robbbb closed this Jul 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants