align indentation in rest of lib with core#979
Merged
EzraBrooks merged 4 commits intodevelopfrom Nov 5, 2025
Merged
Conversation
EzraBrooks
changed the title
Contributor
Author
|
@bjsowa I'll trade you a formatting PR for your formatting PR 😆 |
sea-bass
approved these changes
Nov 5, 2025
bjsowa
requested changes
Nov 5, 2025
Member
bjsowa
left a comment
bjsowa
left a comment
There was a problem hiding this comment.
2 lines is also my preference. I quickly skimmed through it and everything seems properly formatted except for multi-line docstrings which need to be corrected
src/tf/ROS2TFClient.js
Outdated
Comment on lines
12
to
24
| @@ -22,154 +22,154 @@ export default class ROS2TFClient extends EventEmitter { | |||
| * @param {string} [options.serverName="/tf2_web_republisher"] - The name of the tf2_web_republisher server. | |||
| * @param {string} [options.repubServiceName="/republish_tfs"] - The name of the republish_tfs service (non groovy compatibility mode only). | |||
| */ | |||
Member
There was a problem hiding this comment.
The multi-line docstrings seem to have misaligned
EzraBrooks
force-pushed
the
align-indentation-in-rest-of-app-with-core
branch
from
4b93f21 to
fd5a261
Compare
Contributor
Author
|
Good catch @bjsowa, we didn't have any linting applied to multiline comments. I enabled the default setting in ESLint and it cleaned all that up. |
bjsowa
approved these changes
Nov 5, 2025
Member
bjsowa
left a comment
bjsowa
left a comment
There was a problem hiding this comment.
LGTM. @EzraBrooks I'll ping you on my next formatting PR 😄
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
src/coredirectory was two-space indentation (my preference also) but seemingly nothing else was. This PR fixes that and codifies the style in the ESLint config.