This repository was archived by the owner on Nov 5, 2025. It is now read-only.
Conversation
* Add interfaces IExternalComponent and IExternalComponentExtend * Add externalComponents property for IConfigurationExtend * export IExternalComponent * Add interface IExternalComponentLocationOptions * implement the interface IExternalComponentsExtend * export ExternalComponentsExtend * Add externalComponentManager for AppManager * implement AppExternalComponentManager * Implement IExternalComponentBridge * Add getExternalComponentBridge method for AppBridges * export AppExternalComponentManager * Update getConfigurationExtend method for AppAccessorManager * [TEST] Update appBridge and add externalComponentBridge * Update related test scripts * Remove IExternalComponentBridge interface * AppExternalComponentManager maintains the list of all registered components itself * Update test scripts * Add webhooks interface for the external component * Update the interface IExternalComponent * Add description field to the interface IExternalComponent
* update IWebHooks interface * Add util randomString * add AppEmbeddedSDK * move constants to src/client/constants directory * separate initListener from call method * rename initListener to init
This reverts commit 0b88a18.
* chore: change comment style to obtain VS Code Intellisense * feat: add unregisterComponent method We made follwing changes for the AppExternalComponentManager: * add new private property - appTouchedComponents * add new public method unregisterComponent * add new public method getExternalComponent * Add unregisterComponent in the lifecycle methods We need to call unregisterComponent method to remove the corresponding external components from the providedComponents when following AppManager's methods are called: * `unload` is called * `disable` is called <-> Disable an app * `remove` is called <-> Uninstall an app * `updateAppsMarketplaceInfo` is called and validateLicense not pass * `initializeApp` is called and validateLicense not pass * `enableApp` is called but is not success * Add new AppExternalComponentManager method purgeComponent when remove an app from the system, we need delete its external component from both providedComponents map set and appTouchedCompoents map set. * fix: new deployed app registers externalComponents automatically since the new deployed app will try to register their externalComponent when the `initializeApp` method of AppManager is called. This is not expected behavior. We introduce a new parameter `addToProvidedComponents` for the method `registerComponent` to handle the above problem. Without specifying `registerComponent` to true, the app only "declares" it touched the external component when it is initialized. Only if the `enableApp` method is called, the external component will truly added to providedComponents map set, which means we can access it in the `Game Center`.
* Add new location to external components * MODAL (new) * update enum ExternalComponentLocation
* update IWebHooks interface * Add util randomString * add AppEmbeddedSDK * move constants to src/client/constants directory * separate initListener from call method * rename initListener to init * add appId to IExternalComponent interface
|
|
Codecov Report
@@ Coverage Diff @@
## beta #145 +/- ##
=======================================
Coverage ? 56.87%
=======================================
Files ? 79
Lines ? 2639
Branches ? 381
=======================================
Hits ? 1501
Misses ? 1138
Partials ? 0
Continue to review full report at Codecov.
|
Contributor
|
Can we get a better pull request name? |
graywolf336
previously requested changes
Oct 1, 2019
Contributor
graywolf336
left a comment
graywolf336
left a comment
There was a problem hiding this comment.
Overall, some good work but I would like to see some things clarified and/or made consistent with the rest of the code base.
shiqimei
changed the title
shiqimei
changed the title
* Add interfaces IUserInfo and IRoomInfo * Add documentation for the public methods * getUserInfo * getRoomInfo * Rename AppEmbeddedSDK to AppClientEmbeddedSDK * rename to make sure others can see that it's for client-side * add the class documentation for the AppClientEmbeddedSDK * Rename the AppClientEmbeddedSDK methods * Rename to make sure others can see it's for client-side * Add documentation for the IClientRoomInfo and IClientInfo interfaces
* remove tests externalComponentBridge * remove the extra blank line * fix typos and add necessary blank lines * fix a grammar error in comments * Rename names to avoid confusions * rename IExternalComponentsExtend to IExternalComponentExtend * rename externalComponents to externalComponent
d-gubert
changed the title
This was referenced Oct 3, 2019
* Add documentation to register method * wording changes for IExternalComponentExtend
* Revert "Rename names to avoid confusions" This reverts commit d444646. * support multiple external components per app * Add error handlers for AppExternalComponentManager * Add unit tests for two new errors * ExternalComponentAlreadyTouchedError * ExternalComponentNotMatchWithAppError * Add getters for AppExternalComponentManager * Add unit tests for AppExternalComponentManager * did some changes to AppExternalComponentManager according to tests * fix a serious logic error * compare objects after serialization * add space before parenttheses * Modify documentation to state the name unique * Redesign getExternalComponents * Rename providedExternalComponents to registeredExternalComponents * Redesign getExternalComponents * Remove ExternalComponentAlreadyTouchedError * overwrite an external component with the same name * Remove ExternalComponentNotMatchWithAppError * Because of the caller of the method addExternalComponent is apps-engine. So we can trust the appId provided. * Always overwrite the externalComponent.appId to the appId via the method addExternalComponent * Add external components only if it is not empty * Add a new public method getProvidedComponents * Make sure the return is an array
* [ALPHA] Move host logic into apps-engine repo * Rename EClientEmbeddedSDKActions * Remove the word `embedded` from client SDK files * Rename the client SDK to AppsEngineClient * Redesign external component webhooks (#168) * Remove IWebHooks * Remove IWebHooks * Remove webhooks options from IExternalComponentOptions and redesign it Introduce state for external components Add IPreExternalComponentOpenedPrevent handler Add IPostExternalComponentOpened handler * add accessors for IPreExternalComponentOpenedPrevent handler * Add IPostExternalComponentOpened handler Add IPostExternalComponentClosed handler Remove IPreExternalComponentOpenedPrevent * export modules * Update metadata AppMethod * Update AppImplements * Add methods to AppListenerManager * Remove IWebHooks * Remove IWebHooks * Remove webhooks options from IExternalComponentOptions and redesign it Introduce state for external components Add IPreExternalComponentOpenedPrevent handler Add IPostExternalComponentOpened handler * add accessors for IPreExternalComponentOpenedPrevent handler * Add IPostExternalComponentOpened handler Add IPostExternalComponentClosed handler Remove IPreExternalComponentOpenedPrevent * export modules * Update metadata AppMethod * Update AppImplements * Add methods to AppListenerManager * rebase onto move-host-logic * Remove check methods from event handlers * Rename a few interfaces * Rename a few interfaces * Renamings * Refactor * Remove unused files * Make AppsEngineUIClient use the MESSAGE_ID constant
* Add the command `bundle` for bundling SDK * Bundle sdk before publishing
d-gubert
dismissed
graywolf336’s stale review
All requests have been addressed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes: