Conversation
shiqimei
commented
Oct 2, 2019
- remove tests externalComponentBridge
Codecov Report
@@ Coverage Diff @@
## alpha #149 +/- ##
==========================================
- Coverage 59.65% 57.67% -1.98%
==========================================
Files 73 65 -8
Lines 2377 2266 -111
Branches 350 350
==========================================
- Hits 1418 1307 -111
Misses 959 959
Continue to review full report at Codecov.
|
* rename IExternalComponentsExtend to IExternalComponentExtend * rename externalComponents to externalComponent
graywolf336
left a comment
There was a problem hiding this comment.
While I approve of these changes and making them consistent, I am still not sure I understand the single external component requirement. Why are we limiting Apps to just a single external component? (let's move this conversation to the other pull request)
Please see #145 (comment) @graywolf336 . Some of my ideas are there. |