Skip to content
This repository was archived by the owner on Nov 5, 2025. It is now read-only.

Comments

Removing TS compiler#304

Closed
d-gubert wants to merge 2 commits intoalphafrom
remove-ts-compiler
Closed

Removing TS compiler#304
d-gubert wants to merge 2 commits intoalphafrom
remove-ts-compiler

Conversation

@d-gubert
Copy link
Member

@d-gubert d-gubert commented Aug 26, 2020

What? ⛵

Removing the compilation process for the apps. From this point on, we're expecting the apps package to contain their compiled versions already.

This is just part of the project - most of the work will be done on other packages.

Rocket.Chat PR: RocketChat/Rocket.Chat#18687

Why? 🤔

By doing this we achieve:

  • A smaller dependency tree for the package, since we will not require the typescript package anymore.
  • A smaller memory footprint in the Rocket.Chat server, as we will not load typescript in runtime anymore.
  • A smaller surface for compilation errors to happen when updating the Apps-Engine version in a running server.
  • A shorter start-up time for the Rocket.Chat server, as it will not need to compile all installed apps anymore.
  • A more flexible development experience, not tied to the typescript version we ship with the Apps-Engine.

Links 🌎

PS 👀

@d-gubert
Copy link
Member Author

Current state: runs compiled files.

Tests have not been updated (i.e. are failing 😬 )

@d-gubert d-gubert closed this Aug 31, 2020
@d-gubert d-gubert deleted the remove-ts-compiler branch August 31, 2020 22:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant