Skip to content
This repository was archived by the owner on Nov 5, 2025. It is now read-only.

Comments

Reintroduce "Remove ts compiler (#307)"#317

Merged
d-gubert merged 7 commits intoalphafrom
remove-ts-compiler
Oct 21, 2020
Merged

Reintroduce "Remove ts compiler (#307)"#317
d-gubert merged 7 commits intoalphafrom
remove-ts-compiler

Conversation

@d-gubert
Copy link
Member

What? ⛵

Removing the compilation process for the apps. From this point on, we're expecting the apps package to contain their compiled versions already.

This is just part of the project - most of the work will be done on other packages.

Rocket.Chat PR: RocketChat/Rocket.Chat#18687

Why? 🤔

By doing this we achieve:

  • A smaller dependency tree for the package, since we will not require the typescript package anymore.
  • A smaller memory footprint in the Rocket.Chat server, as we will not load typescript in runtime anymore.
  • A smaller surface for compilation errors to happen when updating the Apps-Engine version in a running server.
  • A shorter start-up time for the Rocket.Chat server, as it will not need to compile all installed apps anymore.
  • A more flexible development experience, not tied to the typescript version we ship with the Apps-Engine.

Links 🌎

PS 👀

@codecov
Copy link

codecov bot commented Oct 15, 2020

Codecov Report

Merging #317 into alpha will increase coverage by 1.34%.
The diff coverage is 27.58%.

Impacted file tree graph

@@            Coverage Diff             @@
##            alpha     #317      +/-   ##
==========================================
+ Coverage   50.69%   52.04%   +1.34%     
==========================================
  Files          75       75              
  Lines        2858     2717     -141     
  Branches      436      405      -31     
==========================================
- Hits         1449     1414      -35     
+ Misses       1409     1303     -106     
Impacted Files Coverage Δ
src/server/AppManager.ts 14.78% <0.00%> (+0.39%) ⬆️
src/server/compiler/AppFabricationFulfillment.ts 54.83% <ø> (-6.28%) ⬇️
src/server/misc/Utilities.ts 44.18% <0.00%> (-4.66%) ⬇️
src/server/compiler/AppPackageParser.ts 23.37% <16.66%> (+1.58%) ⬆️
src/server/compiler/AppCompiler.ts 33.33% <75.00%> (+7.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 000e42d...f3f1197. Read the comment docs.

@d-gubert d-gubert requested review from shiqimei and thassiov October 20, 2020 17:09
Copy link
Contributor

@shiqimei shiqimei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@d-gubert d-gubert merged commit 71f8a5e into alpha Oct 21, 2020
@d-gubert d-gubert deleted the remove-ts-compiler branch October 23, 2020 18:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants