Skip to content
This repository was archived by the owner on Nov 5, 2025. It is now read-only.

Comments

Regression: fix module resolution with no compiler#337

Merged
d-gubert merged 1 commit intoalphafrom
fix-module-resolution
Oct 24, 2020
Merged

Regression: fix module resolution with no compiler#337
d-gubert merged 1 commit intoalphafrom
fix-module-resolution

Conversation

@d-gubert
Copy link
Member

What? ⛵

Module resolution had not been adapted to read JS files from package

Why? 🤔

Links 🌎

PS 👀

@d-gubert d-gubert requested a review from thassiov October 24, 2020 01:06
@codecov
Copy link

codecov bot commented Oct 24, 2020

Codecov Report

Merging #337 into alpha will decrease coverage by 0.07%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            alpha     #337      +/-   ##
==========================================
- Coverage   52.04%   51.96%   -0.08%     
==========================================
  Files          75       75              
  Lines        2717     2721       +4     
  Branches      405      406       +1     
==========================================
  Hits         1414     1414              
- Misses       1303     1307       +4     
Impacted Files Coverage Δ
src/server/misc/Utilities.ts 40.42% <0.00%> (-3.77%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71f8a5e...51a072a. Read the comment docs.

@geekgonecrazy
Copy link
Contributor

This is needed by this PR right? RocketChat/Rocket.Chat#18687

@d-gubert
Copy link
Member Author

Yup

@d-gubert d-gubert merged commit 868f26c into alpha Oct 24, 2020
@d-gubert d-gubert deleted the fix-module-resolution branch March 4, 2021 21:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants