Skip to content
This repository was archived by the owner on Nov 5, 2025. It is now read-only.

Comments

[NEW] App onInstall event#404

Merged
d-gubert merged 10 commits intoalphafrom
feat/onInstall-event
Apr 20, 2021
Merged

[NEW] App onInstall event#404
d-gubert merged 10 commits intoalphafrom
feat/onInstall-event

Conversation

@lucassartor
Copy link
Contributor

@lucassartor lucassartor commented Apr 14, 2021

What? ⛵

Added: onInstall event method.

Why? 🤔

Links 🌎

ClickUp Task
Fixes #397

PS 👀

Complements #407

@codecov
Copy link

codecov bot commented Apr 14, 2021

Codecov Report

Merging #404 (868c644) into alpha (16423f9) will increase coverage by 0.33%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            alpha     #404      +/-   ##
==========================================
+ Coverage   49.28%   49.61%   +0.33%     
==========================================
  Files         102      110       +8     
  Lines        3196     3386     +190     
  Branches      471      474       +3     
==========================================
+ Hits         1575     1680     +105     
- Misses       1621     1706      +85     
Impacted Files Coverage Δ
src/server/AppManager.ts 16.07% <0.00%> (-0.60%) ⬇️
src/server/compiler/modules/net.ts 50.00% <0.00%> (-50.00%) ⬇️
...c/server/permissions/checkers/AppInternalBridge.ts 20.00% <0.00%> (-30.00%) ⬇️
...issions/checkers/AppEnvironmentalVariableBridge.ts 30.76% <0.00%> (-29.24%) ⬇️
src/server/permissions/checkers/AppApisBridge.ts 36.36% <0.00%> (-26.14%) ⬇️
...ver/permissions/checkers/AppUiInteractionBridge.ts 44.44% <0.00%> (-22.23%) ⬇️
...server/permissions/checkers/AppActivationBridge.ts 11.11% <0.00%> (-22.23%) ⬇️
src/server/permissions/checkers/AppUploadBridge.ts 25.00% <0.00%> (-21.16%) ⬇️
.../server/permissions/checkers/AppSchedulerBridge.ts 25.00% <0.00%> (-21.16%) ⬇️
src/server/errors/PermissionDeniedError.ts 14.28% <0.00%> (-19.05%) ⬇️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16423f9...868c644. Read the comment docs.

Copy link
Contributor

@thassiov thassiov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. There's just the context thing left to put in the method's argument, right?
EDIT: nvm, for some odd reason I saw only 3 files instead of 5, and the context were in the two that disappeared 🤔

@d-gubert d-gubert changed the title [FEAT] onInstall event [NEW] App onInstall event Apr 20, 2021
@d-gubert d-gubert merged commit 31308d2 into alpha Apr 20, 2021
@d-gubert d-gubert deleted the feat/onInstall-event branch April 20, 2021 21:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request] Get info about who is installing / uninstalling an app

4 participants