This repository was archived by the owner on Nov 5, 2025. It is now read-only.
Conversation
This was referenced Apr 19, 2021
Codecov Report
@@ Coverage Diff @@
## alpha #407 +/- ##
==========================================
- Coverage 49.03% 48.77% -0.26%
==========================================
Files 102 102
Lines 3212 3229 +17
Branches 472 473 +1
==========================================
Hits 1575 1575
- Misses 1637 1654 +17
Continue to review full report at Codecov.
|
graywolf336
previously requested changes
Apr 20, 2021
Contributor
graywolf336
left a comment
There was a problem hiding this comment.
Not sure about wording or the order of operations.
Co-authored-by: Bradley Hilton <graywolf336@craftyn.com>
d-gubert
approved these changes
Apr 20, 2021
Comments have been properly addressed 🙂
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What? ⛵
Added:
onUninstallevent method.Why? 🤔
Links 🌎
ClickUp Task
Fixes #397
PS 👀
Complements #404