Skip to content
This repository was archived by the owner on Nov 5, 2025. It is now read-only.

Comments

[NEW] App onUninstall event#407

Merged
d-gubert merged 5 commits intoalphafrom
feat/onUninstall-event
Apr 20, 2021
Merged

[NEW] App onUninstall event#407
d-gubert merged 5 commits intoalphafrom
feat/onUninstall-event

Conversation

@lucassartor
Copy link
Contributor

@lucassartor lucassartor commented Apr 19, 2021

What? ⛵

Added: onUninstall event method.

Why? 🤔

Links 🌎

ClickUp Task
Fixes #397

PS 👀

Complements #404

@codecov
Copy link

codecov bot commented Apr 19, 2021

Codecov Report

Merging #407 (bd35058) into alpha (31308d2) will decrease coverage by 0.25%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            alpha     #407      +/-   ##
==========================================
- Coverage   49.03%   48.77%   -0.26%     
==========================================
  Files         102      102              
  Lines        3212     3229      +17     
  Branches      472      473       +1     
==========================================
  Hits         1575     1575              
- Misses       1637     1654      +17     
Impacted Files Coverage Δ
src/server/AppManager.ts 15.48% <0.00%> (-0.59%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31308d2...bd35058. Read the comment docs.

Copy link
Contributor

@graywolf336 graywolf336 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about wording or the order of operations.

Co-authored-by: Bradley Hilton <graywolf336@craftyn.com>
@d-gubert d-gubert dismissed graywolf336’s stale review April 20, 2021 22:05

Comments have been properly addressed 🙂

@d-gubert d-gubert changed the title [FEAT] onUninstall event [NEW] App onUninstall event Apr 20, 2021
@d-gubert d-gubert merged commit 3a59f70 into alpha Apr 20, 2021
@d-gubert d-gubert deleted the feat/onUninstall-event branch April 20, 2021 22:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request] Get info about who is installing / uninstalling an app

3 participants