This repository was archived by the owner on Nov 5, 2025. It is now read-only.
feat(deno-runtime): limit timeout of "Pre" listener events to 1s#775
Merged
feat(deno-runtime): limit timeout of "Pre" listener events to 1s#775
Conversation
ricardogarim
approved these changes
Jul 1, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What? ⛵
Add an option to the runtime request functions to allow for ad-hoc overriting of the default timeout configuration (10s)
Why? 🤔
Long time outs on "Pre" listener events were causing actions on the RocketChat side to take too long if a subprocess became faulty
Links 🌎
PS 👀
The API ended up being a bit off due to the current architecture constrains of the
ProxiedApp. We'll need to reevaluate at a later date.