Skip to content

[FIX] App always using the last deep link on Android#4585

Merged
diegolmello merged 3 commits intodevelopfrom
fix.android-infinite-deep-link
Oct 4, 2022
Merged

[FIX] App always using the last deep link on Android#4585
diegolmello merged 3 commits intodevelopfrom
fix.android-infinite-deep-link

Conversation

@diegolmello
Copy link
Member

@diegolmello diegolmello commented Sep 30, 2022

Proposed changes

react-native-notifications has a few issues with Android SDK 31.

Apparently, this fix is not enough

I applied this patch on this PR

Issue(s)

How to test or reproduce

What's been fixed

  • Receive a push notification
  • Tap on it and the app should redirect to it
  • Go to another room and try to send a message
  • (fail) On Android, the app is going to trigger the deep link again and behave like you tapped the push notification again

Other tests

  • Everything related to push notification (ping me if you need help thinking on possible test cases)

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

@diegolmello diegolmello force-pushed the fix.android-infinite-deep-link branch from eecd0ad to d277c8a Compare October 4, 2022 13:25
@diegolmello diegolmello merged commit 5344f2f into develop Oct 4, 2022
@diegolmello diegolmello deleted the fix.android-infinite-deep-link branch October 4, 2022 13:25
ivnxyz pushed a commit to NextiaDev/Rocket.Chat.ReactNative that referenced this pull request May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants