Merged
Conversation
elliscwc
pushed a commit
to taskade/react-native-notifications
that referenced
this pull request
Aug 15, 2022
* bump to rn 67 in example * restrict trampoline fix to targetSdk 31 and above
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As noted in #825 with the fix to trampoline issue on clicking the PN the app is opening a new activity and thus the back button won't lead you to the previous app state. This PR restricts the fix to only when targetSdk is 31 and above because only then trampoline issue is problematic. current version of RN is targeting SDK 30 so we need to think on a better solution in the future.