[NEW] Allow user with required permissions to remove member from room#1637
[NEW] Allow user with required permissions to remove member from room#1637
Conversation
… into feat/kick_user.1319
Codecov Report
@@ Coverage Diff @@
## develop #1637 +/- ##
=========================================
Coverage ? 36.7%
=========================================
Files ? 307
Lines ? 14318
Branches ? 0
=========================================
Hits ? 5256
Misses ? 9062
Partials ? 0
Continue to review full report at Codecov.
|
|
Fixed conflicts and 2 bugs:
|
|
@cardoso I don't think I should be able to remove myself from the room 🤔: |
|
@rafaelks do you think we should remove the option or rename it to "Exit Room" ? |
|
@cardoso Yes, let's not open anything to "myself" for now. |
|
@rafaelks Made your changes and fixed conflicts! |
| didSet { | ||
| UIView.performWithoutAnimation { | ||
| membersTableView?.reloadData() | ||
| } |
There was a problem hiding this comment.
This is causing real weird behaviour on the list... we should be adding new rows instead of reloading the entire tableView. But not required right now. 👍


@RocketChat/ios
Also renames Subscription * Request -> Room * Request. It was starting to get confusing.
Adds test to room roles fetching
Closes #1319