Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1726 +/- ##
==========================================
Coverage ? 34.93%
==========================================
Files ? 312
Lines ? 14344
Branches ? 0
==========================================
Hits ? 5011
Misses ? 9333
Partials ? 0
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
I guess we can remove the // TODO here?
|
@cardoso Nice one! This PR is removing the fallback compatibility for logins with WebSocket already? |
filipealva
left a comment
There was a problem hiding this comment.
Looking good! Ready to merge after solving the conflicts 👍
|
@rafaelks It wasn't needed. I was just doing it if there was any error with the HTTP login, but it shouldn't happen. It's better to remove the code. |
|
@cardoso Got it! Just need to resolve the conflicts then 👍 |
@RocketChat/ios