Fix and improve vietnamese translation#10397
Merged
graywolf336 merged 7 commits intoRocketChat:developfrom Apr 11, 2018
Merged
Conversation
…ub.com/goalifyplus/Goalify.Chat into feature/improve-vietnamese-translation * 'feature/improve-vietnamese-translation' of https://github.com/goalifyplus/Goalify.Chat: improve some vietnamese translation # Conflicts: # packages/rocketchat-i18n/i18n/vi-VN.i18n.json
…ub.com/goalifyplus/Goalify.Chat into feature/improve-vietnamese-translation * 'feature/improve-vietnamese-translation' of https://github.com/goalifyplus/Goalify.Chat: improve some vietnames translation # Conflicts: # packages/rocketchat-i18n/i18n/vi-VN.i18n.json
|
|
Contributor
|
Hey @tttt-conan, thanks for the pull request and fixes! Would you and your co-worker like to be added to our LingoHub project? That way you can do the changes in there? If so, let me know via open.rocket.chat |
graywolf336
approved these changes
Apr 10, 2018
Contributor
graywolf336
left a comment
graywolf336
left a comment
There was a problem hiding this comment.
Thanks again for this!
trongthanh
added a commit
to goalifyplus/Goalify.Chat
that referenced
this pull request
Apr 16, 2018
* goalify: (42 commits) Add Reload as global object update setup script domain to subdomain to setup S3 bucket [OTHER] Post to redhat registries api when tagging new release (RocketChat#10414) add setting Goalify API Gateway and Goalify API Token update initialSetting script to seed 1 time only Fix and improve vietnamese translation (RocketChat#10397) Don't expose the 'settings' property on users to regular users via the rest api (RocketChat#10411) [FIX] Updated OpenShift Template to take an Image as a Param (RocketChat#9946) Use Node 8.9 for CI build Fix incoming integrations being able to trigger a new message with a GET if there is no script enabled (RocketChat#9576) Update allowed labels by the rocket.cat gh bot (RocketChat#10360) [FIX] Snaps installations are breaking on avatar requests Update PULL_REQUEST_TEMPLATE.md Bump version to 0.64.0-develop Bump version to 0.63.1 update dev apn key and cert Lower cased the first letter and removed unnecessary minus Fix: Incorrect French language usage for Disabled snap revert to 8.9.4 Update saml_utils.js ...
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[FIX] Fix and improve Vietnamese translation
Overall Lingohub did a very good job translating English to Vietnamese, some words are quite good translated since Vietnamese is quite difficult to translate. But, some words are still mislead and sometimes are not understandable in the given context. I and my co-worker, who are Vietnamese and are taking part in a project using RocketChat source, have spent some time overall checking and fixed some of them (Ok may be not "some"). So we want to contribute back to RocketChat for creating such a great open-source chat system. They are maybe not perfect but they are understandable by Vietnamese people.