[BREAK] The property "settings" is no longer available to regular users via rest api#10411
Merged
graywolf336 merged 1 commit intodevelopfrom Apr 10, 2018
Merged
[BREAK] The property "settings" is no longer available to regular users via rest api#10411graywolf336 merged 1 commit intodevelopfrom
graywolf336 merged 1 commit intodevelopfrom
Conversation
sampaiodiego
approved these changes
Apr 10, 2018
Member
sampaiodiego
left a comment
sampaiodiego
left a comment
There was a problem hiding this comment.
just change it to [BREAK]
graywolf336
changed the title
trongthanh
added a commit
to goalifyplus/Goalify.Chat
that referenced
this pull request
Apr 16, 2018
* goalify: (42 commits) Add Reload as global object update setup script domain to subdomain to setup S3 bucket [OTHER] Post to redhat registries api when tagging new release (RocketChat#10414) add setting Goalify API Gateway and Goalify API Token update initialSetting script to seed 1 time only Fix and improve vietnamese translation (RocketChat#10397) Don't expose the 'settings' property on users to regular users via the rest api (RocketChat#10411) [FIX] Updated OpenShift Template to take an Image as a Param (RocketChat#9946) Use Node 8.9 for CI build Fix incoming integrations being able to trigger a new message with a GET if there is no script enabled (RocketChat#9576) Update allowed labels by the rocket.cat gh bot (RocketChat#10360) [FIX] Snaps installations are breaking on avatar requests Update PULL_REQUEST_TEMPLATE.md Bump version to 0.64.0-develop Bump version to 0.63.1 update dev apn key and cert Lower cased the first letter and removed unnecessary minus Fix: Incorrect French language usage for Disabled snap revert to 8.9.4 Update saml_utils.js ...
|
So this is a change for 0.64? |
Contributor
|
Yes, this is a change that will be included in the next release (PR is already merged). |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #10401 - regular users won't see that property on the users endpoints anymore, but administrator users will.
Detail: After we added the property
settingsto the users, we forgot to include this property in our array of fields that should not go out to regular users except for when they view their own data via the rest api. The reason this is considered breaking is because we have removed a property that was added, so if you are expecting this property to be there it won't show up. Usually we deprecate these type of things, however, due to the privacy concerns we have immediately removed it.