Support passing extra connection options to the Mongo driver#10529
Support passing extra connection options to the Mongo driver#10529rodrigok merged 13 commits intoRocketChat:developfrom
Conversation
|
|
|
I can't see anywhere obvious to document this. Any pointers? |
|
Have a look at Rocket.Chat/docs. Best place would be somewhere under “Installing and Updating” :) |
server/startup/serverRunning.js
Outdated
There was a problem hiding this comment.
Let's go with typeof mongoOptionStr to stay consistent with the rest of our codebase.
sampaiodiego
left a comment
sampaiodiego
left a comment
There was a problem hiding this comment.
looking at how Mongo.setConnectionOptions works, looks like we cannot call it multiple times.. since we're calling it already, I'll ask you to change there to merge the options received from process.env.MONGO_OPTIONS
- Remove brackets around `typeof` call for consistency with other code - Use `let` instead of `var`
…hat into mongo-connection-options
|
@sampaiodiego Done. |
|
Documentation PR at https://github.com/RocketChat/docs/pull/707 |
|
@graywolf336 / @sampaiodiego any chance you could review this today please? |
8 participants
Fixes #10526