Merged
Conversation
- Remove brackets around `typeof` call for consistency with other code - Use `let` instead of `var`
…hat into mongo-connection-options
…some URLs Original PR was #10496
Dependencies update
[FIX] Regression on 0.64.0 was freezing the application when posting some URLs
…ce-apps Regression: Updating an App on multi-instance servers wasn't working
[FIX] E-mails were hidden some information
Support passing extra connection options to the Mongo driver
…default [NEW] Store the last sent message to show bellow the room's name by default
sampaiodiego
reviewed
May 3, 2018
| }); | ||
|
|
||
| it('it should click the star', () => { | ||
| it.skip('it should click the star', () => { |
Member
There was a problem hiding this comment.
any reason for this being skipped?
Member
Author
There was a problem hiding this comment.
Yeap, it was failing duo to the last message been active, I wasn't able to discover why, so I disabled it
sampaiodiego
approved these changes
May 3, 2018
|
Thanks, ppl for pushing this release forward. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
· 1 🎉 · 2 🐛 · 3 🔍 · 1 👩💻👨💻🎉 New features
🐛 Bug fixes
🔍 Minor changes
👩💻👨💻 Contributors 😍