[FIX] Regression on 0.64.0 was freezing the application when posting some URLs#10627
Merged
[FIX] Regression on 0.64.0 was freezing the application when posting some URLs#10627
Conversation
…some URLs Original PR was #10496
f6ba0e5 to
0d07699
Compare
sampaiodiego
approved these changes
May 1, 2018
|
We had issues that this PR will most likely resolve. As we patched the code in sendMessage to not parse any urls in messages to avoid a regexp hanging when parsing a URL such as this: The offending regexp in sendMessage.js was: Looking forward to a patch release asap :) |
|
Since this seems to affect a lot of installations, and a downgrade is not easily feasible/possible without data loss due to migrations, a quick release would be highly appreciated. Is the review by @gdelavald mandatory? Thanks for all the hard work. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original PR was #10496
closes #10616