[FIX] Auto-hide LiveChat closed rooms#11291
Closed
renatobecker-zz wants to merge 3 commits intodevelopfrom
Closed
Conversation
Member
|
@renatobecker I saw the referenced issue is already closed. so does it still make sense? if so, can you please fix the conflicts? |
Author
|
Closed by #13824. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #11118
Fixes the auto-hide when closing LiveChat rooms. Auto-hiding was not working as expect due to the sequence in which the subscriptions are updated:
Here:https://github.com/RocketChat/Rocket.Chat/blob/develop/packages/rocketchat-livechat/server/lib/Livechat.js#L252
And here:https://github.com/RocketChat/Rocket.Chat/blob/develop/imports/message-read-receipt/server/hooks.js#L11
Now the
RocketChat.models.Subscriptions.hideByRoomIdAndUserIdis called in thelivechat.closeRoomcallback to avoid previous overwrite.Improvement:If the room is closed on the client-side(Livechat widget), an alert will be displayed to notify the agent: