[FIX] Auto hide Livechat room from sidebar on close#13824
Merged
renatobecker-zz merged 4 commits intoRocketChat:developfrom Apr 3, 2019
Merged
[FIX] Auto hide Livechat room from sidebar on close#13824renatobecker-zz merged 4 commits intoRocketChat:developfrom
renatobecker-zz merged 4 commits intoRocketChat:developfrom
Conversation
renatobecker-zz
suggested changes
Apr 1, 2019
| // mark message as read as well | ||
| ReadReceipt.markMessageAsReadBySender(message, room._id, message.u._id); | ||
|
|
||
| if (message.t === 'livechat-close') { |
There was a problem hiding this comment.
This is not a good idea.
Let's check if the room is not closed before calling the method, like this:
if (room && !room.closedAt) {
Subscriptions.setAsReadByRoomIdAndUserId(room._id, message.u._id);
}
But, to make it works fine, you will need to send an updated room object here:
https://github.com/RocketChat/Rocket.Chat/blob/develop/app/livechat/server/lib/Livechat.js#L317
renatobecker-zz
approved these changes
Apr 3, 2019
renatobecker-zz
changed the title
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #11118
cc @renatobecker would you please review